Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: make all headings use var(--bs-emphasis-color) #38262

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 17, 2023

Description

In the main branch, headings of the homepage are all grays:

Screenshot 2023-03-17 at 14 31 41

But this is not the case for the /docs and /examples pages.

This PR suggests using var(--bs-emphasis-color) in .bd-masthead and .masthead-followup headings.

Note: no change of color for the footer headings.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review March 17, 2023 13:39
@julien-deramond julien-deramond requested a review from a team as a code owner March 17, 2023 13:39
site/assets/scss/_content.scss Outdated Show resolved Hide resolved
@julien-deramond julien-deramond force-pushed the main-jd-fix-docs-headers-in-white branch from b47a92d to 1de72bd Compare March 18, 2023 07:26
@mdo mdo merged commit 2d0c94c into main Mar 19, 2023
@mdo mdo deleted the main-jd-fix-docs-headers-in-white branch March 19, 2023 23:57
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants